proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 10:04:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #12980 from FRRouting/mergify/bp/stable/8.5/pr-12974

Browse Source 
bgpd: Increment version number even when no data is sent (backport #12974)
This commit is contained in:
Donatas Abraitis 2023-03-13 07:11:48 +02:00 committed by GitHub
commit c353c87453
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
bgpd/bgp_updgrp_adv.c
View File

@ -512,6 +512,23 @@ void bgp_adj_out_set_subgroup(struct bgp_dest *dest,
zlog_debug("%s suppress UPDATE w/ attr: %s", peer->host, zlog_debug("%s suppress UPDATE w/ attr: %s", peer->host,
attr_str); attr_str);
} }
/*
* If BGP is skipping sending this value to it's peers
* the version number should be updated just like it
* would if it sent the data. Why? Because update
* groups will not be coalesced until such time that
* the version numbers are the same.
*
* Imagine a scenario with say 2 peers and they come
* up and are placed in the same update group. Then
* a new peer comes up a bit later. Then a prefix is
* flapped that we decide for the first 2 peers are
* mapped to and we decide not to send the data to
* it. Then unless more network changes happen we
* will never be able to coalesce the 3rd peer down
*/
subgrp->version = MAX(subgrp->version, dest->version);
return; return;
} }