proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 12:39:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: Fix SA issue with stream s read

Browse Source 
We were checking for non-null of 'struct stream *s'
after we did a stream_getl, which would have crashed
the program.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2017-02-01 19:43:43 -05:00
parent e46538e628
commit c28e5b2a83
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/zclient.c
View File

@ -1146,11 +1146,15 @@ struct interface *
zebra_interface_link_params_read (struct stream *s) zebra_interface_link_params_read (struct stream *s)
{ {
struct if_link_params *iflp; struct if_link_params *iflp;
uint32_t ifindex = stream_getl (s); ifindex_t ifindex;
assert (s);
ifindex = stream_getl (s);
struct interface *ifp = if_lookup_by_index (ifindex); struct interface *ifp = if_lookup_by_index (ifindex);
if (ifp == NULL || s == NULL) if (ifp == NULL)
{ {
zlog_err ("%s: unknown ifindex %u, shouldn't happen", zlog_err ("%s: unknown ifindex %u, shouldn't happen",
__func__, ifindex); __func__, ifindex);