proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-02 16:25:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: add ability to show all types of valgrind memleaks

Browse Source 
Signed-off-by: Christian Hopps <chopps@labn.net>
This commit is contained in:
Christian Hopps 2023-11-07 15:27:33 -05:00
parent cf51579b5b
commit c27b054efe
3 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
doc/developer/topotests.rst
View File

@ -639,11 +639,14 @@ Detecting Memleaks with Valgrind
""""""""""""""""""""""""""""""""
Topotest can automatically launch all daemons with ``valgrind`` to check for
memleaks. This is enabled by specifying 1 or 2 CLI arguments.
``--valgrind-memleaks`` will enable general memleak detection, and
``--valgrind-extra`` enables extra functionality including generating a
suppression file. The suppression file ``tools/valgrind.supp`` is used when
memleak detection is enabled.
memleaks. This is enabled by specifying 1 to 3 CLI arguments.
``--valgrind-memleaks`` enables memleak detection. ``--valgrind-extra`` enables
extra functionality including generating a suppression file. The suppression
file ``tools/valgrind.supp`` is used when memleak detection is enabled. Finally,
``--valgrind-leak-kinds=KINDS`` can be used to modify what types of links are
reported. This corresponds to valgrind's ``--show-link-kinds`` arg. The value is
either ``all`` or a comma-separated list of types:
``definite,indirect,possible,reachable``. The default is ``definite,possible``.
.. code:: shell

6
tests/topotests/conftest.py
View File

@ -208,6 +208,12 @@ def pytest_addoption(parser):
help="Generate suppression file, and enable more precise (slower) valgrind checks",
)
parser.addoption(
"--valgrind-leak-kinds",
metavar="KIND[,KIND...]",
help="Comma-separated list of valgrind leak kinds or 'all'",
)
parser.addoption(
"--valgrind-memleaks",
action="store_true",

3
tests/topotests/lib/topotest.py
View File

@ -1806,6 +1806,7 @@ class Router(Node):
gdb_routers = g_pytest_config.get_option_list("--gdb-routers")
gdb_use_emacs = bool(g_pytest_config.option.gdb_use_emacs)
valgrind_extra = bool(g_pytest_config.option.valgrind_extra)
valgrind_leak_kinds = g_pytest_config.option.valgrind_leak_kinds
valgrind_memleaks = bool(g_pytest_config.option.valgrind_memleaks)
strace_daemons = g_pytest_config.get_option_list("--strace-daemons")
@ -1938,6 +1939,8 @@ class Router(Node):
f" --log-file={valgrind_logbase}.%p"
f" --leak-check=full --suppressions={supp_file}"
)
if valgrind_leak_kinds:
cmdenv += f" --show-leak-kinds={valgrind_leak_kinds}"
if valgrind_extra:
cmdenv += (
" --gen-suppressions=all --expensive-definedness-checks=yes"