From c195ae78e957c4783e078d4b2eff0065f76e817c Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Wed, 4 Nov 2020 09:11:13 -0500 Subject: [PATCH] pbrd: Fix memory leak in json output Fix a memory leak in using some pbr json commands. Signed-off-by: Donald Sharp --- pbrd/pbr_vty.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/pbrd/pbr_vty.c b/pbrd/pbr_vty.c index eb51516c24..26163dcc56 100644 --- a/pbrd/pbr_vty.c +++ b/pbrd/pbr_vty.c @@ -907,16 +907,22 @@ DEFPY (show_pbr_interface, if (j) this_iface = json_object_new_object(); - if (!ifp->info) + if (!ifp->info) { + json_object_free(this_iface); continue; + } - if (name && strcmp(ifp->name, name) != 0) + if (name && strcmp(ifp->name, name) != 0) { + json_object_free(this_iface); continue; + } pbr_ifp = ifp->info; - if (strcmp(pbr_ifp->mapname, "") == 0) + if (strcmp(pbr_ifp->mapname, "") == 0) { + json_object_free(this_iface); continue; + } pbrm = pbrm_find(pbr_ifp->mapname);