proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-13 09:56:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: Check received prefixes before immediately sending dynamic capabilities

Browse Source 
If we send capabilities immediately, before receiving an UPDATE message, we end up
with a notification received from the neighbor. Let's wait until we have the fully
converged topology and do the stuff.

Tested locally and can't replicate the failure, let's see how happy is the CI this time.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2023-11-08 16:36:07 +02:00
parent f6d708bc80
commit c12b976c0a
5 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
tests/topotests/bgp_dynamic_capability/test_bgp_dynamic_capability_addpath.py
View File

@ -70,6 +70,11 @@ def test_bgp_dynamic_capability_addpath():
}
},
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
}
}
return topotest.json_cmp(output, expected)
@ -108,6 +113,11 @@ def test_bgp_dynamic_capability_addpath():
}
},
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
"messageStats": {
"notificationsRecv": 0,
"capabilityRecv": 1,

10
tests/topotests/bgp_dynamic_capability/test_bgp_dynamic_capability_graceful_restart.py
View File

@ -68,6 +68,11 @@ def test_bgp_dynamic_capability_graceful_restart():
"gracefulRestart": "advertisedAndReceived",
"longLivedGracefulRestart": "advertisedAndReceived",
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
"gracefulRestartInfo": {
"nBit": True,
"timers": {
@ -116,6 +121,11 @@ def test_bgp_dynamic_capability_graceful_restart():
"gracefulRestart": "advertisedAndReceived",
"longLivedGracefulRestart": "advertisedAndReceived",
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
"gracefulRestartInfo": {
"nBit": True,
"timers": {

6
tests/topotests/bgp_dynamic_capability/test_bgp_dynamic_capability_orf.py
View File

@ -64,6 +64,11 @@ def test_bgp_dynamic_capability_orf():
"neighborCapabilities": {
"dynamic": "advertisedAndReceived",
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
}
}
return topotest.json_cmp(output, expected)
@ -116,6 +121,7 @@ def test_bgp_dynamic_capability_orf():
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 1,
"afDependentCap": {
"orfPrefixList": {
"sendMode": "advertisedAndReceived",

10
tests/topotests/bgp_dynamic_capability/test_bgp_dynamic_capability_role.py
View File

@ -66,6 +66,11 @@ def test_bgp_dynamic_capability_role():
"neighborCapabilities": {
"dynamic": "advertisedAndReceived",
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
}
}
return topotest.json_cmp(output, expected)
@ -108,6 +113,11 @@ def test_bgp_dynamic_capability_role():
"dynamic": "advertisedAndReceived",
"role": "advertisedAndReceived",
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
"messageStats": {
"notificationsRecv": 0,
"capabilityRecv": 1,

10
tests/topotests/bgp_dynamic_capability/test_bgp_dynamic_capability_software_version.py
View File

@ -68,6 +68,11 @@ def test_bgp_dynamic_capability_software_version():
"receivedSoftwareVersion": None,
},
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
}
}
return topotest.json_cmp(output, expected)
@ -129,6 +134,11 @@ def test_bgp_dynamic_capability_software_version():
"receivedSoftwareVersion": rcv,
},
},
"addressFamilyInfo": {
"ipv4Unicast": {
"acceptedPrefixCounter": 3,
}
},
"messageStats": {
"notificationsRecv": 0,
"capabilityRecv": 1,