mirror of
				https://git.proxmox.com/git/mirror_frr
				synced 2025-11-03 23:47:16 +00:00 
			
		
		
		
	tests: Check received prefixes before immediately sending dynamic capabilities
If we send capabilities immediately, before receiving an UPDATE message, we end up with a notification received from the neighbor. Let's wait until we have the fully converged topology and do the stuff. Tested locally and can't replicate the failure, let's see how happy is the CI this time. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
		
							parent
							
								
									cc75bdf026
								
							
						
					
					
						commit
						b80bc3fd14
					
				@ -68,6 +68,11 @@ def test_bgp_dynamic_capability_graceful_restart():
 | 
			
		||||
                    "gracefulRestart": "advertisedAndReceived",
 | 
			
		||||
                    "longLivedGracefulRestart": "advertisedAndReceived",
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
                "gracefulRestartInfo": {
 | 
			
		||||
                    "nBit": True,
 | 
			
		||||
                    "timers": {
 | 
			
		||||
@ -116,6 +121,11 @@ def test_bgp_dynamic_capability_graceful_restart():
 | 
			
		||||
                    "gracefulRestart": "advertisedAndReceived",
 | 
			
		||||
                    "longLivedGracefulRestart": "advertisedAndReceived",
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
                "gracefulRestartInfo": {
 | 
			
		||||
                    "nBit": True,
 | 
			
		||||
                    "timers": {
 | 
			
		||||
 | 
			
		||||
@ -66,6 +66,11 @@ def test_bgp_dynamic_capability_role():
 | 
			
		||||
                "neighborCapabilities": {
 | 
			
		||||
                    "dynamic": "advertisedAndReceived",
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        return topotest.json_cmp(output, expected)
 | 
			
		||||
@ -108,6 +113,11 @@ def test_bgp_dynamic_capability_role():
 | 
			
		||||
                    "dynamic": "advertisedAndReceived",
 | 
			
		||||
                    "role": "advertisedAndReceived",
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
                "messageStats": {
 | 
			
		||||
                    "notificationsRecv": 0,
 | 
			
		||||
                    "capabilityRecv": 1,
 | 
			
		||||
 | 
			
		||||
@ -68,6 +68,11 @@ def test_bgp_dynamic_capability_software_version():
 | 
			
		||||
                        "receivedSoftwareVersion": None,
 | 
			
		||||
                    },
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
            }
 | 
			
		||||
        }
 | 
			
		||||
        return topotest.json_cmp(output, expected)
 | 
			
		||||
@ -129,6 +134,11 @@ def test_bgp_dynamic_capability_software_version():
 | 
			
		||||
                        "receivedSoftwareVersion": rcv,
 | 
			
		||||
                    },
 | 
			
		||||
                },
 | 
			
		||||
                "addressFamilyInfo": {
 | 
			
		||||
                    "ipv4Unicast": {
 | 
			
		||||
                        "acceptedPrefixCounter": 2,
 | 
			
		||||
                    }
 | 
			
		||||
                },
 | 
			
		||||
                "messageStats": {
 | 
			
		||||
                    "notificationsRecv": 0,
 | 
			
		||||
                    "capabilityRecv": 1,
 | 
			
		||||
 | 
			
		||||
		Loading…
	
		Reference in New Issue
	
	Block a user