From 344b4a29bf41577c25d1bfc2db62f22f412a7c0d Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sat, 25 Aug 2018 18:26:01 -0400 Subject: [PATCH 1/3] isisd: Include header for function declaration isis_handle_pdu is called but not declared for usage by not including the appropriate header. Signed-off-by: Donald Sharp --- isisd/isis_bpf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/isisd/isis_bpf.c b/isisd/isis_bpf.c index d05dba33ee..7e8a4a4eda 100644 --- a/isisd/isis_bpf.c +++ b/isisd/isis_bpf.c @@ -43,6 +43,7 @@ #include "isisd/isis_constants.h" #include "isisd/isis_circuit.h" #include "isisd/isis_network.h" +#include "isisd/isis_pdu.h" #include "privs.h" From 184ce1c5d16850c56830ad02a6cb22151f553cf8 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sat, 25 Aug 2018 18:27:11 -0400 Subject: [PATCH 2/3] lib: Cleanup uninted `top` variable in ferr.c The `top` variable could possibly be used without any initialization, remove the possibility. Signed-off-by: Donald Sharp --- lib/ferr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ferr.c b/lib/ferr.c index d1b9d514b4..17ec51c4bf 100644 --- a/lib/ferr.c +++ b/lib/ferr.c @@ -107,7 +107,7 @@ struct log_ref *log_ref_get(uint32_t code) void log_ref_display(struct vty *vty, uint32_t code, bool json) { struct log_ref *ref; - struct json_object *top, *obj; + struct json_object *top = NULL, *obj = NULL; struct list *errlist; struct listnode *ln; From f7dae31211dedf2e66f7d8bebdc9ff7f148eceef Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Sat, 25 Aug 2018 18:28:19 -0400 Subject: [PATCH 3/3] zebra: No prototype and uninited variables Add a header to cleanup no declaration and properly wrapper some variables to appropriate #ifdef. Signed-off-by: Donald Sharp --- zebra/if_ioctl.c | 1 + zebra/zebra_vxlan.c | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/zebra/if_ioctl.c b/zebra/if_ioctl.c index d17a9cf498..176bb2bbad 100644 --- a/zebra/if_ioctl.c +++ b/zebra/if_ioctl.c @@ -37,6 +37,7 @@ #include "zebra/interface.h" #include "zebra/rib.h" +#include "zebra/rt.h" #include diff --git a/zebra/zebra_vxlan.c b/zebra/zebra_vxlan.c index f63879159d..b0fc0a39bd 100644 --- a/zebra/zebra_vxlan.c +++ b/zebra/zebra_vxlan.c @@ -1558,7 +1558,9 @@ static int zvni_neigh_install(zebra_vni_t *zvni, zebra_neigh_t *n) struct zebra_if *zif; struct zebra_l2info_vxlan *vxl; struct interface *vlan_if; +#ifdef GNU_LINUX uint8_t flags; +#endif int ret = 0; if (!(n->flags & ZEBRA_NEIGH_REMOTE)) @@ -3369,7 +3371,9 @@ static int zl3vni_nh_del(zebra_l3vni_t *zl3vni, zebra_neigh_t *n) */ static int zl3vni_nh_install(zebra_l3vni_t *zl3vni, zebra_neigh_t *n) { +#ifdef GNU_LINUX uint8_t flags; +#endif int ret = 0; if (!is_l3vni_oper_up(zl3vni))