proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-16 01:12:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix incorrect thread list processing loops

Browse Source 
* thread.c: (thread_timer_process,thread_process) thread_list_delete nulls
  thread->next. Loops need to save next first, or will only process the head.
  Problem noted by Lou Berger <lberger@labn.net>.
This commit is contained in:
Paul Jakma 2012-02-28 18:32:56 +00:00
parent b51a3a3150
commit b5043aabb0
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/thread.c
View File

@ -972,10 +972,12 @@ static unsigned int
thread_timer_process (struct thread_list *list, struct timeval *timenow) thread_timer_process (struct thread_list *list, struct timeval *timenow)
{ {
struct thread *thread; struct thread *thread;
struct thread *next;
unsigned int ready = 0; unsigned int ready = 0;
for (thread = list->head; thread; thread = thread->next) for (thread = list->head; thread; thread = next)
{ {
next = thread->next;
if (timeval_cmp (*timenow, thread->u.sands) < 0) if (timeval_cmp (*timenow, thread->u.sands) < 0)
return ready; return ready;
thread_list_delete (list, thread); thread_list_delete (list, thread);
@ -991,10 +993,12 @@ static unsigned int
thread_process (struct thread_list *list) thread_process (struct thread_list *list)
{ {
struct thread *thread; struct thread *thread;
struct thread *next;
unsigned int ready = 0; unsigned int ready = 0;
for (thread = list->head; thread; thread = thread->next) for (thread = list->head; thread; thread = next)
{ {
next = thread->next;
thread_list_delete (list, thread); thread_list_delete (list, thread);
thread->type = THREAD_READY; thread->type = THREAD_READY;
thread_list_add (&thread->master->ready, thread); thread_list_add (&thread->master->ready, thread);