proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 03:47:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

[ripd] bug #293: routemap set metric doesn't check for underflow correctly

Browse Source 
2006-09-11 Paul Jakma <paul.jakma@sun.com>

	* rip_routemap.c: (route_set_metric) underflow check needs to
	  use signed, problem identified and diagnosed by Pavel
	  Nikiforov in bug #293.
This commit is contained in:
Paul Jakma 2006-09-11 02:14:16 +00:00
parent 3e557ae1ea
commit b25ea4d085
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ripd/ChangeLog
View File

@ -2,6 +2,9 @@
* ripd.c: (rip_read) remove gratuitous use of mid-function * ripd.c: (rip_read) remove gratuitous use of mid-function
declaration of vrecv, bug #278. declaration of vrecv, bug #278.
* rip_routemap.c: (route_set_metric) underflow check needs to
use signed, problem identified and diagnosed by Pavel
Nikiforov in bug #293.
2006-06-29 Paul Jakma <paul.jakma@sun.com> 2006-06-29 Paul Jakma <paul.jakma@sun.com>

2
ripd/rip_routemap.c
View File

@ -530,7 +530,7 @@ route_set_metric (void *rule, struct prefix *prefix,
else if (mod->type == metric_absolute) else if (mod->type == metric_absolute)
rinfo->metric_out = mod->metric; rinfo->metric_out = mod->metric;
if (rinfo->metric_out < 1) if ((signed int)rinfo->metric_out < 1)
rinfo->metric_out = 1; rinfo->metric_out = 1;
if (rinfo->metric_out > RIP_METRIC_INFINITY) if (rinfo->metric_out > RIP_METRIC_INFINITY)
rinfo->metric_out = RIP_METRIC_INFINITY; rinfo->metric_out = RIP_METRIC_INFINITY;