topotests: Cleanup diagnose_env to allow thought about multi-platforms

Start the cleanup of diagnose_env to allow the running of topotests
on platforms besides linux.

So we split up diagnose_env into linux and freebsd variants.
At this point in time freebsd doesn't have any special code.
To be determined in the future.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2018-12-15 10:49:59 -05:00
parent 8b26284ba1
commit af99f19eb2

View File

@ -908,7 +908,7 @@ class TopoExaBGP(TopoHost):
# Disable linter branch warning. It is expected to have these here.
# pylint: disable=R0912
def diagnose_env():
def diagnose_env_linux():
"""
Run diagnostics in the running environment. Returns `True` when everything
is ok, otherwise `False`.
@ -1066,3 +1066,14 @@ def diagnose_env():
logger.removeHandler(fhandler)
return ret
def diagnose_env_freebsd():
return True
def diagnose_env():
if sys.platform.startswith("linux"):
return diagnose_env_linux()
elif sys.platform.startswith("freebsd"):
return diagnose_env_freebsd()
return False