From ae88ba4b52653d8c6e53ee2cd818aa73f5aaa1de Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 9 Jun 2023 09:25:29 -0400 Subject: [PATCH] tests: Fix missing assert for test case in bgp_suppress_fib Test was attempting to test the 60.0.0.0 route but was querying 10.0.0.3 and ignoring the result. Let's fix it. Signed-off-by: Donald Sharp --- tests/topotests/bgp_suppress_fib/test_bgp_suppress_fib.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/topotests/bgp_suppress_fib/test_bgp_suppress_fib.py b/tests/topotests/bgp_suppress_fib/test_bgp_suppress_fib.py index ef9200b197..fd8a78b485 100644 --- a/tests/topotests/bgp_suppress_fib/test_bgp_suppress_fib.py +++ b/tests/topotests/bgp_suppress_fib/test_bgp_suppress_fib.py @@ -94,7 +94,6 @@ def test_bgp_route(): expected, ) _, result = topotest.run_and_expect(test_func, None, count=10, wait=0.5) - assertmsg = '"r3" JSON output mismatches' assert result is None, assertmsg json_file = "{}/r3/v4_route3.json".format(CWD) @@ -103,10 +102,11 @@ def test_bgp_route(): test_func = partial( topotest.router_json_cmp, r3, - "show ip route 10.0.0.3 json", + "show ip route 60.0.0.0 json", expected, ) _, result = topotest.run_and_expect(test_func, None, count=10, wait=0.5) + assert result is None, assertmsg def test_bgp_better_admin_won():