Merge pull request #13635 from donaldsharp/give_ping_a_chance

tests: Actually loop if ping fails
This commit is contained in:
Jafar Al-Gharaibeh 2023-05-30 18:59:44 -05:00 committed by GitHub
commit adea8ef308
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -98,7 +98,8 @@ def check_ping4(name, dest_addr, expect_connected):
tgen = get_topogen() tgen = get_topogen()
output = tgen.gears[name].run("ping {} -c 1 -w 1".format(dest_addr)) output = tgen.gears[name].run("ping {} -c 1 -w 1".format(dest_addr))
logger.info(output) logger.info(output)
assert match in output, "ping fail" if match not in output:
return "ping fail"
match = ", {} packet loss".format("0%" if expect_connected else "100%") match = ", {} packet loss".format("0%" if expect_connected else "100%")
logger.info("[+] check {} {} {}".format(name, dest_addr, match)) logger.info("[+] check {} {} {}".format(name, dest_addr, match))