Merge pull request #9611 from donaldsharp/more_default_bull

when doing a switch over an enumeration do not use default
This commit is contained in:
Russ White 2021-09-15 09:06:49 -04:00 committed by GitHub
commit a79c6892bc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 17 deletions

View File

@ -634,9 +634,6 @@ const char *nexthop2str(const struct nexthop *nexthop, char *str, int size)
case NEXTHOP_TYPE_BLACKHOLE: case NEXTHOP_TYPE_BLACKHOLE:
snprintf(str, size, "blackhole"); snprintf(str, size, "blackhole");
break; break;
default:
snprintf(str, size, "unknown");
break;
} }
return str; return str;
@ -993,12 +990,10 @@ static ssize_t printfrr_nh(struct fbuf *buf, struct printfrr_eargs *ea,
case BLACKHOLE_NULL: case BLACKHOLE_NULL:
ret += bputs(buf, " (blackhole)"); ret += bputs(buf, " (blackhole)");
break; break;
default: case BLACKHOLE_UNSPEC:
break; break;
} }
break; break;
default:
break;
} }
if (do_ifi && nexthop->ifindex) if (do_ifi && nexthop->ifindex)
ret += bprintfrr(buf, ", %s%s", v_viaif, ret += bprintfrr(buf, ", %s%s", v_viaif,
@ -1029,9 +1024,6 @@ static ssize_t printfrr_nh(struct fbuf *buf, struct printfrr_eargs *ea,
case NEXTHOP_TYPE_BLACKHOLE: case NEXTHOP_TYPE_BLACKHOLE:
ret += bputs(buf, "blackhole"); ret += bputs(buf, "blackhole");
break; break;
default:
ret += bputs(buf, "unknown");
break;
} }
return ret; return ret;
} }

View File

@ -353,8 +353,6 @@ static void show_nexthop_detail_helper(struct vty *vty,
break; break;
} }
break; break;
default:
break;
} }
if (re->vrf_id != nexthop->vrf_id) { if (re->vrf_id != nexthop->vrf_id) {
@ -605,8 +603,6 @@ static void show_route_nexthop_helper(struct vty *vty,
break; break;
} }
break; break;
default:
break;
} }
if ((re == NULL || (nexthop->vrf_id != re->vrf_id))) if ((re == NULL || (nexthop->vrf_id != re->vrf_id)))
@ -777,8 +773,6 @@ static void show_nexthop_json_helper(json_object *json_nexthop,
break; break;
} }
break; break;
default:
break;
} }
if (nexthop->vrf_id != re->vrf_id) if (nexthop->vrf_id != re->vrf_id)
@ -2247,8 +2241,6 @@ static void show_ip_route_nht_dump(struct vty *vty, struct nexthop *nexthop,
break; break;
} }
break; break;
default:
break;
} }
} }