proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2026-01-08 19:06:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #1882 from LabNConsulting/working/master/community-dismiss

Browse Source 
workflow.rst: add note that author's shouldn't delete a comment or review
This commit is contained in:
Martin Winter 2018-04-03 15:54:27 +01:00 committed by GitHub
commit a329ad23cf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
doc/developer/workflow.rst
View File

@ -256,7 +256,15 @@ After submitting your changes
- Wait for reviewers. Someone will review your code or be assigned
to review your code.
- Respond to any comments or concerns the reviewer has.
- Respond to any comments or concerns the reviewer has. Use e-mail or
add a comment via github to respond or to let the reviewer know how
their comment or concern is addressed.
- An author must never delete or manually dismiss someone else's comments
or review. (A review may be overridden by agreement in the weekly
technical meeting.)
- Automatically generated comments, e.g., those generated by CI systems,
may be deleted by authors and others when such comments are not the most
recent results from that automated comment source.
- After all comments and concerns are addressed, expect your patch
to be merged.