proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-14 12:41:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Unlock bgp_node after bgp_node_lookup

Browse Source 
bgp_node_lookup increments lock, we should decrement it after use.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2022-07-27 14:51:15 +03:00
parent e8e28f4f4c
commit a25ae82fd4
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bgpd/bgp_bmp.c
View File

@ -992,7 +992,7 @@ afibreak:
} }
struct bgp_table *table = bmp->targets->bgp->rib[afi][safi]; struct bgp_table *table = bmp->targets->bgp->rib[afi][safi];
struct bgp_dest *bn; struct bgp_dest *bn = NULL;
struct bgp_path_info *bpi = NULL, *bpiter; struct bgp_path_info *bpi = NULL, *bpiter;
struct bgp_adj_in *adjin = NULL, *adjiter; struct bgp_adj_in *adjin = NULL, *adjiter;
@ -1120,6 +1120,9 @@ afibreak:
bmp_monitor(bmp, adjin->peer, 0, bn_p, prd, adjin->attr, afi, bmp_monitor(bmp, adjin->peer, 0, bn_p, prd, adjin->attr, afi,
safi, adjin->uptime); safi, adjin->uptime);
if (bn)
bgp_dest_unlock_node(bn);
return true; return true;
} }
@ -1145,7 +1148,7 @@ static bool bmp_wrqueue(struct bmp *bmp, struct pullwr *pullwr)
{ {
struct bmp_queue_entry *bqe; struct bmp_queue_entry *bqe;
struct peer *peer; struct peer *peer;
struct bgp_dest *bn; struct bgp_dest *bn = NULL;
bool written = false; bool written = false;
bqe = bmp_pull(bmp); bqe = bmp_pull(bmp);
@ -1220,6 +1223,10 @@ static bool bmp_wrqueue(struct bmp *bmp, struct pullwr *pullwr)
out: out:
if (!bqe->refcount) if (!bqe->refcount)
XFREE(MTYPE_BMP_QUEUE, bqe); XFREE(MTYPE_BMP_QUEUE, bqe);
if (bn)
bgp_dest_unlock_node(bn);
return written; return written;
} }