proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 01:37:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix a memory leak in FreeBSD

Browse Source 
Two important changes:
* Centralize the thread teardown procedure;
* Save and restore thread mutex context to avoid losing the memory
  pointer;

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
(cherry picked from commit 6655966d2c)
This commit is contained in:
Rafael Zalamena 2018-09-25 12:05:53 -03:00 committed by Rafael Zalamena
parent c8c24278b1
commit a0350aed12
1 changed files with 26 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
lib/thread.c
View File

@ -57,6 +57,7 @@ pthread_key_t thread_current;
pthread_mutex_t masters_mtx = PTHREAD_MUTEX_INITIALIZER; pthread_mutex_t masters_mtx = PTHREAD_MUTEX_INITIALIZER;
static struct list *masters; static struct list *masters;
static void thread_free(struct thread_master *master, struct thread *thread);
/* CLI start ---------------------------------------------------------------- */ /* CLI start ---------------------------------------------------------------- */
static unsigned int cpu_record_hash_key(struct cpu_thread_history *a) static unsigned int cpu_record_hash_key(struct cpu_thread_history *a)
@ -537,6 +538,8 @@ static struct thread *thread_trim_head(struct thread_list *list)
/* Move thread to unuse list. */ /* Move thread to unuse list. */
static void thread_add_unuse(struct thread_master *m, struct thread *thread) static void thread_add_unuse(struct thread_master *m, struct thread *thread)
{ {
pthread_mutex_t mtxc = thread->mtx;
assert(m != NULL && thread != NULL); assert(m != NULL && thread != NULL);
assert(thread->next == NULL); assert(thread->next == NULL);
assert(thread->prev == NULL); assert(thread->prev == NULL);
@ -545,10 +548,15 @@ static void thread_add_unuse(struct thread_master *m, struct thread *thread)
memset(thread, 0, sizeof(struct thread)); memset(thread, 0, sizeof(struct thread));
thread->type = THREAD_UNUSED; thread->type = THREAD_UNUSED;
if (m->unuse.count < THREAD_UNUSED_DEPTH) /* Restore the thread mutex context. */
thread->mtx = mtxc;
if (m->unuse.count < THREAD_UNUSED_DEPTH) {
thread_list_add(&m->unuse, thread); thread_list_add(&m->unuse, thread);
else return;
XFREE(MTYPE_THREAD, thread); }
thread_free(m, thread);
} }
/* Free all unused thread. */ /* Free all unused thread. */
@ -559,9 +567,8 @@ static void thread_list_free(struct thread_master *m, struct thread_list *list)
for (t = list->head; t; t = next) { for (t = list->head; t; t = next) {
next = t->next; next = t->next;
XFREE(MTYPE_THREAD, t); thread_free(m, t);
list->count--; list->count--;
m->alloc--;
} }
} }
@ -575,8 +582,7 @@ static void thread_array_free(struct thread_master *m,
t = thread_array[index]; t = thread_array[index];
if (t) { if (t) {
thread_array[index] = NULL; thread_array[index] = NULL;
XFREE(MTYPE_THREAD, t); thread_free(m, t);
m->alloc--;
} }
} }
XFREE(MTYPE_THREAD_POLL, thread_array); XFREE(MTYPE_THREAD_POLL, thread_array);
@ -587,9 +593,8 @@ static void thread_queue_free(struct thread_master *m, struct pqueue *queue)
int i; int i;
for (i = 0; i < queue->size; i++) for (i = 0; i < queue->size; i++)
XFREE(MTYPE_THREAD, queue->array[i]); thread_free(m, queue->array[i]);
m->alloc -= queue->size;
pqueue_delete(queue); pqueue_delete(queue);
} }
@ -607,8 +612,7 @@ void thread_master_free_unused(struct thread_master *m)
{ {
struct thread *t; struct thread *t;
while ((t = thread_trim_head(&m->unuse)) != NULL) { while ((t = thread_trim_head(&m->unuse)) != NULL) {
pthread_mutex_destroy(&t->mtx); thread_free(m, t);
XFREE(MTYPE_THREAD, t);
} }
} }
pthread_mutex_unlock(&m->mtx); pthread_mutex_unlock(&m->mtx);
@ -727,6 +731,17 @@ static struct thread *thread_get(struct thread_master *m, uint8_t type,
return thread; return thread;
} }
static void thread_free(struct thread_master *master, struct thread *thread)
{
/* Update statistics. */
assert(master->alloc > 0);
master->alloc--;
/* Free allocated resources. */
pthread_mutex_destroy(&thread->mtx);
XFREE(MTYPE_THREAD, thread);
}
static int fd_poll(struct thread_master *m, struct pollfd *pfds, nfds_t pfdsize, static int fd_poll(struct thread_master *m, struct pollfd *pfds, nfds_t pfdsize,
nfds_t count, const struct timeval *timer_wait) nfds_t count, const struct timeval *timer_wait)
{ {