From 98cc8dd47383f6eeb4593ae6766e007d163a019c Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Thu, 19 Nov 2020 20:46:55 -0500 Subject: [PATCH 1/2] vtysh: Start deprecation cycle for `address-family evpn` Signed-off-by: Donald Sharp --- vtysh/vtysh.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c index 243a7c943f..75b57c8e75 100644 --- a/vtysh/vtysh.c +++ b/vtysh/vtysh.c @@ -1720,11 +1720,16 @@ DEFUNSH(VTYSH_BGPD, address_family_evpn, address_family_evpn_cmd, } #if defined(HAVE_CUMULUS) +#if CONFDATE > 20211115 +CPP_NOTICE("Use of `address-family evpn` is deprecated please remove don't forget frr-reload.py") +#endif DEFUNSH_HIDDEN(VTYSH_BGPD, address_family_evpn2, address_family_evpn2_cmd, "address-family evpn", "Enter Address Family command mode\n" "EVPN Address family\n") { + vty_out(vty, + "This command is deprecated please convert to `address-family l2vpn evpn`\n"); vty->node = BGP_EVPN_NODE; return CMD_SUCCESS; } From 50121ac041d8e3e0d3e03d8898540a87bf8f2832 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 20 Nov 2020 08:00:08 -0500 Subject: [PATCH 2/2] bgpd: Remove restriction on certain connection types under HAVE_CUMULUS Current code when we are establishing a peering relationship when under the HAVE_CUMULUS block will dissallow v4/v6 connections if we do not have v4/v6 addresses applied. This restriction is a bit harsh and should be allowed but warned against. Signed-off-by: Donald Sharp --- bgpd/bgp_packet.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c index 3d73e34235..cf7a265b11 100644 --- a/bgpd/bgp_packet.c +++ b/bgpd/bgp_packet.c @@ -1393,13 +1393,8 @@ static int bgp_open_receive(struct peer *peer, bgp_size_t size) || peer->afc_nego[AFI_IP][SAFI_ENCAP]) { if (peer->nexthop.v4.s_addr == INADDR_ANY) { #if defined(HAVE_CUMULUS) - flog_err( - EC_BGP_SND_FAIL, - "%s: No local IPv4 addr resetting connection, fd %d", - peer->host, peer->fd); - bgp_notify_send(peer, BGP_NOTIFY_CEASE, - BGP_NOTIFY_SUBCODE_UNSPECIFIC); - return BGP_Stop; + zlog_warn("%s: No local IPv4 addr, BGP routing may not work", + peer->host); #endif } } @@ -1410,13 +1405,8 @@ static int bgp_open_receive(struct peer *peer, bgp_size_t size) || peer->afc_nego[AFI_IP6][SAFI_ENCAP]) { if (IN6_IS_ADDR_UNSPECIFIED(&peer->nexthop.v6_global)) { #if defined(HAVE_CUMULUS) - flog_err( - EC_BGP_SND_FAIL, - "%s: No local IPv6 addr resetting connection, fd %d", - peer->host, peer->fd); - bgp_notify_send(peer, BGP_NOTIFY_CEASE, - BGP_NOTIFY_SUBCODE_UNSPECIFIC); - return BGP_Stop; + zlog_warn("%s: No local IPv6 address, BGP routing may not work", + peer->host); #endif } }