proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-04 06:55:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: logger masked in topotest.py

Browse Source 
a local logger masks the global logger and prevents errors from being
gracefully handled within topotest.py

Signed-off-by: Liam Brady <lbrady@labn.net>
(cherry picked from commit 1b38f33041)
This commit is contained in:
Liam Brady 2024-10-17 13:35:36 -04:00 committed by Mergify
parent f4f0e2cd38
commit 9a830b3cf4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tests/topotests/lib/topotest.py
View File

@ -1244,8 +1244,8 @@ def _sysctl_assure(commander, variable, value):
def sysctl_atleast(commander, variable, min_value, raises=False):
try:
if commander is None:
logger = logging.getLogger("topotest")
commander = micronet.Commander("sysctl", logger=logger)
topotest_logger = logging.getLogger("topotest")
commander = micronet.Commander("sysctl", logger=topotest_logger)
return _sysctl_atleast(commander, variable, min_value)
except subprocess.CalledProcessError as error:
@ -1262,8 +1262,8 @@ def sysctl_atleast(commander, variable, min_value, raises=False):
def sysctl_assure(commander, variable, value, raises=False):
try:
if commander is None:
logger = logging.getLogger("topotest")
commander = micronet.Commander("sysctl", logger=logger)
topotest_logger = logging.getLogger("topotest")
commander = micronet.Commander("sysctl", logger=topotest_logger)
return _sysctl_assure(commander, variable, value)
except subprocess.CalledProcessError as error:
logger.warning(