proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-07 05:42:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd : Ambiguous command: show bgp large-community-list 1

Browse Source 
When user wants to dump individual large-community-list with the name
then bgp throws an error. It is due to command to dump the bgp RIB routes
having a particular large-community-list values. To segregate both the
commands this fix has added the detail keyword in the below command.
show bgp large-community-list <(1-500)|WORD> detail
The same code change is applicable for community-list also.

Signed-off-by: vishaldhingra<vdhingra@vmware.com>
This commit is contained in:
vdhingra 2019-08-12 04:15:29 -07:00
parent f067bdf8e2
commit 960b69b9df
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
bgpd/bgp_vty.c
View File

@ -14452,12 +14452,13 @@ ALIAS (show_community_list,
DEFUN (show_community_list_arg, DEFUN (show_community_list_arg,
show_bgp_community_list_arg_cmd, show_bgp_community_list_arg_cmd,
"show bgp community-list <(1-500)|WORD>", "show bgp community-list <(1-500)|WORD> detail",
SHOW_STR SHOW_STR
BGP_STR BGP_STR
"List community-list\n" "List community-list\n"
"Community-list number\n" "Community-list number\n"
"Community-list name\n") "Community-list name\n"
"Detailed information on community-list\n")
{ {
int idx_comm_list = 3; int idx_comm_list = 3;
struct community_list *list; struct community_list *list;
@ -14466,8 +14467,8 @@ DEFUN (show_community_list_arg,
if (argv_find(argv, argc, "ip", &idx)) { if (argv_find(argv, argc, "ip", &idx)) {
vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n"); vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n");
vty_out(vty, "if you are using this please migrate to the below command.\n"); vty_out(vty, "if you are using this please migrate to the below command.\n");
vty_out(vty, "'show bgp community-list <(1-500)|WORD>'\n"); vty_out(vty, "'show bgp community-list <(1-500)|WORD> detail'\n");
zlog_warn("Deprecated option: 'ip show community-list <(1-500)|WORD>' being used"); zlog_warn("Deprecated option: 'show ip community-list <(1-500)|WORD>' being used");
} }
list = community_list_lookup(bgp_clist, argv[idx_comm_list]->arg, 0, list = community_list_lookup(bgp_clist, argv[idx_comm_list]->arg, 0,
COMMUNITY_LIST_MASTER); COMMUNITY_LIST_MASTER);
@ -14977,12 +14978,13 @@ ALIAS (show_lcommunity_list,
DEFUN (show_lcommunity_list_arg, DEFUN (show_lcommunity_list_arg,
show_bgp_lcommunity_list_arg_cmd, show_bgp_lcommunity_list_arg_cmd,
"show bgp large-community-list <(1-500)|WORD>", "show bgp large-community-list <(1-500)|WORD> detail",
SHOW_STR SHOW_STR
BGP_STR BGP_STR
"List large-community list\n" "List large-community list\n"
"large-community-list number\n" "Large-community-list number\n"
"large-community-list name\n") "Large-community-list name\n"
"Detailed information on large-community-list\n")
{ {
struct community_list *list; struct community_list *list;
int idx = 0; int idx = 0;
@ -14990,14 +14992,14 @@ DEFUN (show_lcommunity_list_arg,
if (argv_find(argv, argc, "ip", &idx)) { if (argv_find(argv, argc, "ip", &idx)) {
vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n"); vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n");
vty_out(vty, "if you are using this please migrate to the below command.\n"); vty_out(vty, "if you are using this please migrate to the below command.\n");
vty_out(vty, "'show bgp large-community-list <(1-500)|WORD>'\n"); vty_out(vty, "'show bgp large-community-list <(1-500)|WORD> detail'\n");
zlog_warn("Deprecated option: 'ip show large-community-list <(1-500)|WORD>' being used"); zlog_warn("Deprecated option: 'show ip large-community-list <(1-500)|WORD>' being used");
} }
list = community_list_lookup(bgp_clist, argv[3]->arg, 0, list = community_list_lookup(bgp_clist, argv[3]->arg, 0,
LARGE_COMMUNITY_LIST_MASTER); LARGE_COMMUNITY_LIST_MASTER);
if (!list) { if (!list) {
vty_out(vty, "%% Can't find extcommunity-list\n"); vty_out(vty, "%% Can't find large-community-list\n");
return CMD_WARNING; return CMD_WARNING;
} }
@ -15378,12 +15380,13 @@ ALIAS (show_extcommunity_list,
DEFUN (show_extcommunity_list_arg, DEFUN (show_extcommunity_list_arg,
show_bgp_extcommunity_list_arg_cmd, show_bgp_extcommunity_list_arg_cmd,
"show bgp extcommunity-list <(1-500)|WORD>", "show bgp extcommunity-list <(1-500)|WORD> detail",
SHOW_STR SHOW_STR
BGP_STR BGP_STR
"List extended-community list\n" "List extended-community list\n"
"Extcommunity-list number\n" "Extcommunity-list number\n"
"Extcommunity-list name\n") "Extcommunity-list name\n"
"Detailed information on extcommunity-list\n")
{ {
int idx_comm_list = 3; int idx_comm_list = 3;
struct community_list *list; struct community_list *list;
@ -15392,8 +15395,8 @@ DEFUN (show_extcommunity_list_arg,
if (argv_find(argv, argc, "ip", &idx)) { if (argv_find(argv, argc, "ip", &idx)) {
vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n"); vty_out(vty, "This config option is deprecated, and is scheduled for removal.\n");
vty_out(vty, "if you are using this please migrate to the below command.\n"); vty_out(vty, "if you are using this please migrate to the below command.\n");
vty_out(vty, "'show bgp extcommunity-list <(1-500)|WORD>'\n"); vty_out(vty, "'show bgp extcommunity-list <(1-500)|WORD> detail'\n");
zlog_warn("Deprecated option: 'ip show extcommunity-list <(1-500)|WORD>' being used"); zlog_warn("Deprecated option: 'show ip extcommunity-list <(1-500)|WORD>' being used");
} }
list = community_list_lookup(bgp_clist, argv[idx_comm_list]->arg, 0, list = community_list_lookup(bgp_clist, argv[idx_comm_list]->arg, 0,
EXTCOMMUNITY_LIST_MASTER); EXTCOMMUNITY_LIST_MASTER);