mirror of
https://git.proxmox.com/git/mirror_frr
synced 2025-08-05 11:48:50 +00:00
isisd: fix crash during candidate validation
The "abort_if_not_found" parameter of nb_running_get_entry() should be set to true only when this function is called during the NB_EV_APPLY phase of a northbound callback. Failure to respect this can lead to crashes when multiple configuration changes are being committed at the same time. Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
parent
463ef4b2a7
commit
952ef7cc90
@ -1534,9 +1534,9 @@ static int lib_interface_isis_create(enum nb_event event,
|
||||
/* check if interface mtu is sufficient. If the area has not
|
||||
* been created yet, assume default MTU for the area
|
||||
*/
|
||||
ifp = nb_running_get_entry(dnode, NULL, true);
|
||||
ifp = nb_running_get_entry(dnode, NULL, false);
|
||||
/* zebra might not know yet about the MTU - nothing we can do */
|
||||
if (ifp->mtu == 0)
|
||||
if (!ifp || ifp->mtu == 0)
|
||||
break;
|
||||
actual_mtu =
|
||||
if_is_broadcast(ifp) ? ifp->mtu - LLC_LEN : ifp->mtu;
|
||||
|
Loading…
Reference in New Issue
Block a user