proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-05 08:23:56 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

isisd: fix crash during candidate validation

Browse Source 
The "abort_if_not_found" parameter of nb_running_get_entry()
should be set to true only when this function is called during the
NB_EV_APPLY phase of a northbound callback. Failure to respect this
can lead to crashes when multiple configuration changes are being
committed at the same time.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
Renato Westphal 2019-09-23 09:37:49 -03:00
parent 463ef4b2a7
commit 952ef7cc90
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
isisd/isis_northbound.c
View File

@ -1534,9 +1534,9 @@ static int lib_interface_isis_create(enum nb_event event,
/* check if interface mtu is sufficient. If the area has not /* check if interface mtu is sufficient. If the area has not
* been created yet, assume default MTU for the area * been created yet, assume default MTU for the area
*/ */
ifp = nb_running_get_entry(dnode, NULL, true); ifp = nb_running_get_entry(dnode, NULL, false);
/* zebra might not know yet about the MTU - nothing we can do */ /* zebra might not know yet about the MTU - nothing we can do */
if (ifp->mtu == 0) if (!ifp || ifp->mtu == 0)
break; break;
actual_mtu = actual_mtu =
if_is_broadcast(ifp) ? ifp->mtu - LLC_LEN : ifp->mtu; if_is_broadcast(ifp) ? ifp->mtu - LLC_LEN : ifp->mtu;