proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 15:17:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix prefix2str return value and assert

Browse Source 
Signed-off-by: Christian Franke <chris@opensourcerouting.org>
This commit is contained in:
Christian Franke 2016-11-21 19:39:10 +01:00 committed by Christian Franke
parent d987f2339d
commit 942e4486d8
1 changed files with 13 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
lib/prefix.c
View File

@ -893,29 +893,22 @@ const char *
prefix2str (union prefix46constptr pu, char *str, int size) prefix2str (union prefix46constptr pu, char *str, int size)
{ {
const struct prefix *p = pu.p; const struct prefix *p = pu.p;
char buf[PREFIX2STR_BUFFER];
if (p->family == AF_ETHERNET) { if (p->family == AF_ETHERNET)
int i; {
char *s = str; snprintf(str, size, "%02x:%02x:%02x:%02x:%02x:%02x/%d",
p->u.prefix_eth.octet[0], p->u.prefix_eth.octet[1],
assert(size > (3*ETHER_ADDR_LEN) + 1 /* slash */ + 3 /* plen */ ); p->u.prefix_eth.octet[2], p->u.prefix_eth.octet[3],
for (i = 0; i < ETHER_ADDR_LEN; ++i) { p->u.prefix_eth.octet[4], p->u.prefix_eth.octet[5],
sprintf(s, "%02x", p->u.prefix_eth.octet[i]); p->prefixlen);
if (i < (ETHER_ADDR_LEN - 1)) { }
*(s+2) = ':'; else
s += 3; {
} else { char buf[PREFIX2STR_BUFFER];
s += 2; inet_ntop(p->family, &p->u.prefix, buf, sizeof(buf));
} snprintf(str, size, "%s/%d", buf, p->prefixlen);
} }
sprintf(s, "/%d", p->prefixlen);
return 0;
}
snprintf (str, size, "%s/%d",
inet_ntop (p->family, &p->u.prefix, buf, PREFIX2STR_BUFFER),
p->prefixlen);
return str; return str;
} }