proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-10-31 20:23:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: when verifying a route is missing use expected=False

Browse Source 
Prior to this the full retry cycle was run with a "passing" negative
result each time through

Previous runtime ~5 minutes
New runtime ~20 seconds.

Signed-off-by: Christian Hopps <chopps@labn.net>
This commit is contained in:
Christian Hopps 2023-03-31 16:39:11 +00:00
parent 4fe50326b9
commit 8fb2082229
1 changed files with 13 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/topotests/mgmt_tests/test_yang_mgmt.py
View File

@ -217,7 +217,9 @@ def test_mgmt_commit_check(request):
] ]
} }
} }
result = verify_rib(tgen, "ipv4", dut, input_dict_4, protocol=protocol) result = verify_rib(
tgen, "ipv4", dut, input_dict_4, protocol=protocol, expected=False
)
assert ( assert (
result is not True result is not True
), "Testcase {} : Failed" "Error: Routes is missing in RIB".format(tc_name) ), "Testcase {} : Failed" "Error: Routes is missing in RIB".format(tc_name)
@ -319,7 +321,9 @@ def test_mgmt_commit_abort(request):
] ]
} }
} }
result = verify_rib(tgen, "ipv4", dut, input_dict_4, protocol=protocol) result = verify_rib(
tgen, "ipv4", dut, input_dict_4, protocol=protocol, expected=False
)
assert ( assert (
result is not True result is not True
), "Testcase {} : Failed" "Error: Routes is missing in RIB".format(tc_name) ), "Testcase {} : Failed" "Error: Routes is missing in RIB".format(tc_name)
@ -387,7 +391,9 @@ def test_mgmt_delete_config(request):
assert result is True, "Testcase {} : Failed Error: {}".format(tc_name, result) assert result is True, "Testcase {} : Failed Error: {}".format(tc_name, result)
step("Verify that the route is deleted from RIB") step("Verify that the route is deleted from RIB")
result = verify_rib(tgen, "ipv4", dut, input_dict_4, protocol=protocol) result = verify_rib(
tgen, "ipv4", dut, input_dict_4, protocol=protocol, expected=False
)
assert ( assert (
result is not True result is not True
), "Testcase {} : Failed" "Error: Routes is still present in RIB".format(tc_name) ), "Testcase {} : Failed" "Error: Routes is still present in RIB".format(tc_name)
@ -461,7 +467,9 @@ def test_mgmt_chaos_stop_start_frr(request):
dut = "r1" dut = "r1"
protocol = "static" protocol = "static"
input_dict_4 = {"r1": {"static_routes": [{"network": "192.1.11.200/32"}]}} input_dict_4 = {"r1": {"static_routes": [{"network": "192.1.11.200/32"}]}}
result = verify_rib(tgen, "ipv4", dut, input_dict_4, protocol=protocol) result = verify_rib(
tgen, "ipv4", dut, input_dict_4, protocol=protocol, expected=False
)
assert ( assert (
result is not True result is not True
), "Testcase {} : Failed" "Error: Routes still present in RIB".format(tc_name) ), "Testcase {} : Failed" "Error: Routes still present in RIB".format(tc_name)