From 8f126928f7ab461bd81e3637b4eb509d6038fc5e Mon Sep 17 00:00:00 2001 From: Donatas Abraitis Date: Wed, 29 Mar 2023 23:21:35 +0300 Subject: [PATCH] bgpd: Do not call bgp_soft_reconfig_in() twice in a row on policy change Just realized it was a stupid copy/paste. Signed-off-by: Donatas Abraitis --- bgpd/bgpd.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c index 43885883ea..97238bc38b 100644 --- a/bgpd/bgpd.c +++ b/bgpd/bgpd.c @@ -5677,11 +5677,8 @@ void peer_on_policy_change(struct peer *peer, afi_t afi, safi_t safi, if (bgp_soft_reconfig_in(peer, afi, safi)) return; - if (CHECK_FLAG(peer->af_flags[afi][safi], - PEER_FLAG_SOFT_RECONFIG)) - bgp_soft_reconfig_in(peer, afi, safi); - else if (CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_OLD_RCV) || - CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_NEW_RCV)) + if (CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_OLD_RCV) || + CHECK_FLAG(peer->cap, PEER_CAP_REFRESH_NEW_RCV)) bgp_route_refresh_send(peer, afi, safi, 0, 0, 0, BGP_ROUTE_REFRESH_NORMAL); }