proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 00:31:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #9677 from ton31337/fix/zlog_newline_not_needed

Browse Source 
tools: Add coccinelle script to catch \n or \r at the end of zlog_*
This commit is contained in:
Donald Sharp 2021-09-28 10:44:54 -04:00 committed by GitHub
commit 8e55e2c87b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/coccinelle/zlog_no_newline.cocci Normal file
View File

@ -0,0 +1,20 @@
// zlog_* should not have \n or \r at the end usually.
// spatch --sp-file tools/coccinelle/zlog_no_newline.cocci --macro-file tools/cocci.h ./ 2>/dev/null
@r@
expression fmt;
identifier func =~ "zlog_";
position p;
@@
(
func(fmt)@p
|
func(fmt, ...)@p
)
@script:python@
fmt << r.fmt;
p << r.p;
@@
if "\\n" in str(fmt) or "\\r" in str(fmt):
print("Newline in logging function detected %s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt))