From 8d8f12ba8e5cd11c189b8475b05539fa8415ccb9 Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Mon, 8 Apr 2024 16:24:05 -0400 Subject: [PATCH] zebra: Actually display I/O buffer sizes An operator found a situation where zebra was backing up in a significant way towards BGP with EVPN changes taking up some serious amounts of memory. The key lines that would have clued us in on it were behind a dev build. Let's change this. Signed-off-by: Donald Sharp --- lib/stream.h | 2 -- zebra/zserv.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/stream.h b/lib/stream.h index 85eebb47be..61eaa46c95 100644 --- a/lib/stream.h +++ b/lib/stream.h @@ -105,9 +105,7 @@ struct stream_fifo { /* number of streams in this fifo */ atomic_size_t count; -#if defined DEV_BUILD atomic_size_t max_count; -#endif struct stream *head; struct stream *tail; diff --git a/zebra/zserv.c b/zebra/zserv.c index e2681289b1..27668534ee 100644 --- a/zebra/zserv.c +++ b/zebra/zserv.c @@ -1125,12 +1125,10 @@ static void zebra_show_client_detail(struct vty *vty, struct zserv *client) vty_out(vty, "ES-EVI %-12u%-12u%-12u\n", client->local_es_evi_add_cnt, 0, client->local_es_evi_del_cnt); vty_out(vty, "Errors: %u\n", client->error_cnt); - -#if defined DEV_BUILD vty_out(vty, "Input Fifo: %zu:%zu Output Fifo: %zu:%zu\n", client->ibuf_fifo->count, client->ibuf_fifo->max_count, client->obuf_fifo->count, client->obuf_fifo->max_count); -#endif + vty_out(vty, "\n"); }