proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-09 09:22:32 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: delete_vin_type2_route may free dest

Browse Source 
The dest pointer may be freed( but should not be
due to locking ).  Let's ensure that this assumption
is true and make coverity happy.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2023-09-10 09:15:41 -04:00
parent f491b54079
commit 8d39c8c927
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
bgpd/bgp_evpn.c
View File

@ -2578,7 +2578,8 @@ static void delete_global_type2_routes(struct bgp *bgp, struct bgpevpn *vpn)
} }
} }
static void delete_vni_type2_route(struct bgp *bgp, struct bgp_dest *dest) static struct bgp_dest *delete_vni_type2_route(struct bgp *bgp,
struct bgp_dest *dest)
{ {
struct bgp_path_info *pi; struct bgp_path_info *pi;
afi_t afi = AFI_L2VPN; afi_t afi = AFI_L2VPN;
@ -2588,13 +2589,15 @@ static void delete_vni_type2_route(struct bgp *bgp, struct bgp_dest *dest)
(const struct prefix_evpn *)bgp_dest_get_prefix(dest); (const struct prefix_evpn *)bgp_dest_get_prefix(dest);
if (evp->prefix.route_type != BGP_EVPN_MAC_IP_ROUTE) if (evp->prefix.route_type != BGP_EVPN_MAC_IP_ROUTE)
return; return dest;
delete_evpn_route_entry(bgp, afi, safi, dest, &pi); delete_evpn_route_entry(bgp, afi, safi, dest, &pi);
/* Route entry in local table gets deleted immediately. */ /* Route entry in local table gets deleted immediately. */
if (pi) if (pi)
bgp_path_info_reap(dest, pi); dest = bgp_path_info_reap(dest, pi);
return dest;
} }
static void delete_vni_type2_routes(struct bgp *bgp, struct bgpevpn *vpn) static void delete_vni_type2_routes(struct bgp *bgp, struct bgpevpn *vpn)
@ -2605,12 +2608,16 @@ static void delete_vni_type2_routes(struct bgp *bgp, struct bgpevpn *vpn)
* routes. * routes.
*/ */
for (dest = bgp_table_top(vpn->mac_table); dest; for (dest = bgp_table_top(vpn->mac_table); dest;
dest = bgp_route_next(dest)) dest = bgp_route_next(dest)) {
delete_vni_type2_route(bgp, dest); dest = delete_vni_type2_route(bgp, dest);
assert(dest);
}
for (dest = bgp_table_top(vpn->ip_table); dest; for (dest = bgp_table_top(vpn->ip_table); dest;
dest = bgp_route_next(dest)) dest = bgp_route_next(dest)) {
delete_vni_type2_route(bgp, dest); dest = delete_vni_type2_route(bgp, dest);
assert(dest);
}
} }
/* /*