proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-14 19:05:37 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: fix label lost when vrf loopback comes back

Browse Source 
VRF-label association drops when the VRF loopback goes down, however, it
does not return once the interface is enabled again.

Logs show that when VRF loopback goes down, a label drop message is sent
to zebra and immediately resent label installation to zebra, trigged by
"vpn_leak_postchange_all()":
2024/07/16 13:26:29 BGP: [RVJ1J-J2T22] ifp down r1-cust1 vrf id 7
2024/07/16 13:26:29 BGP: [WA2QY-06STJ] vpn_leak_zebra_vrf_label_withdraw: deleting label for vrf VRF r1-cust1 (id=7)
2024/07/16 13:26:30 BGP: [S82AC-6YAC8] vpn_leak_zebra_vrf_label_update: vrf VRF r1-cust1: afi IPv4: setting label 80 for vrf id 7

Since the interface is down, the netlink message is not send to kernel.
Once the interface comes back, zebra ignore the installation assuming
the label is already seen.

To fix this, add a check for the interface status before attempting to
reinstall the label.

Signed-off-by: Loïc Sang <loic.sang@6wind.com>
This commit is contained in:
Loïc Sang 2024-07-16 14:03:11 +02:00
parent cc3519f3e6
commit 8b81f32e97
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
bgpd/bgp_mplsvpn.c
View File

@ -280,7 +280,8 @@ done:
* *
* Sending this vrf-label association is qualified by a) whether vrf->vpn * Sending this vrf-label association is qualified by a) whether vrf->vpn
* exporting is active ("export vpn" is enabled, vpn-policy RD and RT list * exporting is active ("export vpn" is enabled, vpn-policy RD and RT list
* are set) and b) whether vpn-policy label is set. * are set), b) whether vpn-policy label is set and c) the vrf loopback
* interface is up.
* *
* If any of these conditions do not hold, then we send MPLS_LABEL_NONE * If any of these conditions do not hold, then we send MPLS_LABEL_NONE
* for this vrf, which zebra interprets to mean "delete this vrf-label * for this vrf, which zebra interprets to mean "delete this vrf-label
@ -288,6 +289,7 @@ done:
*/ */
void vpn_leak_zebra_vrf_label_update(struct bgp *bgp, afi_t afi) void vpn_leak_zebra_vrf_label_update(struct bgp *bgp, afi_t afi)
{ {
struct interface *ifp;
mpls_label_t label = MPLS_LABEL_NONE; mpls_label_t label = MPLS_LABEL_NONE;
int debug = BGP_DEBUG(vpn, VPN_LEAK_LABEL); int debug = BGP_DEBUG(vpn, VPN_LEAK_LABEL);
@ -301,7 +303,9 @@ void vpn_leak_zebra_vrf_label_update(struct bgp *bgp, afi_t afi)
} }
if (vpn_leak_to_vpn_active(bgp, afi, NULL, false)) { if (vpn_leak_to_vpn_active(bgp, afi, NULL, false)) {
label = bgp->vpn_policy[afi].tovpn_label; ifp = if_get_vrf_loopback(bgp->vrf_id);
if (ifp && if_is_vrf(ifp) && if_is_up(ifp))
label = bgp->vpn_policy[afi].tovpn_label;
} }
if (debug) { if (debug) {