proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 22:30:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Fix SA warning found by clang.

Browse Source 
Quiet the SA warning, with an assert.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2018-04-11 12:41:55 -04:00
parent 020a3f60bd
commit 89d5934783
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
bgpd/bgp_mplsvpn.c
View File

@ -1557,6 +1557,18 @@ void vrf_unimport_from_vrf(struct bgp *bgp, struct bgp *vrf_bgp,
vpn_leak_postchange(idir, afi, bgp_get_default(), bgp); vpn_leak_postchange(idir, afi, bgp_get_default(), bgp);
} }
/*
* What?
* So SA is assuming that since the ALL_LIST_ELEMENTS_RO
* below is checking for NULL that export_vrf can be
* NULL, consequently it is complaining( like a cabbage )
* that we could dereference and crash in the listcount(..)
* check below.
* So make it happy, under protest, with liberty and justice
* for all.
*/
assert(vrf_bgp->vpn_policy[afi].export_vrf);
/* Remove us from "import_vrf's" export list. If no other VRF /* Remove us from "import_vrf's" export list. If no other VRF
* is importing from "import_vrf", cleanup appropriately. * is importing from "import_vrf", cleanup appropriately.
*/ */