proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-08 12:49:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra: Allow set src X to work on startup

Browse Source 
If a route-map in zebra has `set src X` and the interface
X is on has not been configured yet, we are rejecting the command
outright.  This is a problem on boot up especially( and where I
found this issue ) in that interfaces *can* and *will* be slow
on startup and config can easily be read in *before* the
interface has an ip address.

Let's modify zebra to just warn to the user we may have a problem
and let the chips fall where they may.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2020-11-13 12:06:57 -05:00 committed by Donatas Abraitis
parent 26c1b54c3c
commit 88ee29355a
1 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
zebra/zebra_nb_config.c
View File

@ -1455,11 +1455,14 @@ int lib_route_map_entry_set_action_source_v4_modify(
if (pif != NULL) if (pif != NULL)
break; break;
} }
if (pif == NULL) { /*
zlog_warn("%s: is not a local adddress: %s", __func__, * On startup the local address *may* not have come up
yang_dnode_get_string(args->dnode, NULL)); * yet. We need to allow startup configuration of
return NB_ERR_VALIDATION; * set src or we are fudged. Log it for future fun
} */
if (pif == NULL)
zlog_warn("set src %pI4 is not a local address",
&p.u.prefix4);
return NB_OK; return NB_OK;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT:
@ -1521,11 +1524,14 @@ int lib_route_map_entry_set_action_source_v6_modify(
if (pif != NULL) if (pif != NULL)
break; break;
} }
if (pif == NULL) { /*
zlog_warn("%s: is not a local adddress: %s", __func__, * On startup the local address *may* not have come up
yang_dnode_get_string(args->dnode, NULL)); * yet. We need to allow startup configuration of
return NB_ERR_VALIDATION; * set src or we are fudged. Log it for future fun
} */
if (pif == NULL)
zlog_warn("set src %pI6 is not a local address",
&p.u.prefix6);
return NB_OK; return NB_OK;
case NB_EV_PREPARE: case NB_EV_PREPARE:
case NB_EV_ABORT: case NB_EV_ABORT: