From 852f96eb036a1bfba878467dc5b378d62f8c87ca Mon Sep 17 00:00:00 2001 From: Donald Sharp Date: Fri, 21 Apr 2023 07:54:00 -0400 Subject: [PATCH] bgpd: All paths have already de-refed rd_str Coverity points out that rd_str has already been deref'ed in all paths leading to this spot. No need to keep at it. Signed-off-by: Donald Sharp --- bgpd/bgp_route.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c index 7809d9b0a9..40ecdbb670 100644 --- a/bgpd/bgp_route.c +++ b/bgpd/bgp_route.c @@ -7038,8 +7038,8 @@ int bgp_static_set_safi(afi_t afi, safi_t safi, struct vty *vty, bgp_static->label = label; bgp_static->prd = prd; - if (rd_str) - bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str); + bgp_static->prd_pretty = XSTRDUP(MTYPE_BGP, rd_str); + if (rmap_str) { XFREE(MTYPE_ROUTE_MAP_NAME, bgp_static->rmap.name); route_map_counter_decrement(bgp_static->rmap.map);