From 84fd92c80e207e879632eb0b640e378074bab8cf Mon Sep 17 00:00:00 2001 From: David Lamparter Date: Thu, 17 Oct 2024 14:26:29 +0200 Subject: [PATCH] tests: remove `strncpy()` use `checkpatch` has sufficiently annoyed me to fix this. Signed-off-by: David Lamparter --- tests/helpers/c/prng.c | 9 +++++---- tests/isisd/test_fuzz_isis_tlv.c | 2 +- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/helpers/c/prng.c b/tests/helpers/c/prng.c index 612c433443..c72615475b 100644 --- a/tests/helpers/c/prng.c +++ b/tests/helpers/c/prng.c @@ -49,16 +49,17 @@ const char *prng_fuzz(struct prng *prng, const char *string, const char *charset, unsigned int operations) { static char buf[256]; - unsigned int charset_len; + size_t charset_len = strlen(charset); + size_t str_len = strlen(string); unsigned int i; unsigned int offset; unsigned int op; unsigned int character; - assert(strlen(string) < sizeof(buf)); + assert(str_len < sizeof(buf)); - strncpy(buf, string, sizeof(buf)); - charset_len = strlen(charset); + memset(buf, 0, sizeof(buf)); + memcpy(buf, string, str_len); for (i = 0; i < operations; i++) { offset = prng_rand(prng) % strlen(buf); diff --git a/tests/isisd/test_fuzz_isis_tlv.c b/tests/isisd/test_fuzz_isis_tlv.c index 627ccfee6f..9d460cd9c1 100644 --- a/tests/isisd/test_fuzz_isis_tlv.c +++ b/tests/isisd/test_fuzz_isis_tlv.c @@ -43,7 +43,7 @@ static char *sortlines(char *in) } if (line_count == 1) { - strncpy(rv, in, rv_len); + memcpy(rv, in, rv_len); return rv; }