proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-11-01 12:47:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bfdd: generate random session identificators

Browse Source 
This also avoids returning `session_id == 0` which should not happen.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
This commit is contained in:
Rafael Zalamena 2019-02-01 09:50:06 -02:00
parent 6f4beb7b30
commit 843b324ddd
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
bfdd/bfd.c
View File

@ -100,9 +100,18 @@ struct bfd_session *bs_peer_find(struct bfd_peer_cfg *bpc)
static uint32_t ptm_bfd_gen_ID(void)
{
static uint32_t sessionID = 1;
uint32_t session_id;
return (sessionID++);
/*
* RFC 5880, Section 6.8.1. recommends that we should generate
* random session identification numbers.
*/
do {
session_id = ((random() << 16) & 0xFFFF0000)
| (random() & 0x0000FFFF);
} while (session_id == 0 || bfd_id_lookup(session_id) != NULL);
return session_id;
}
void ptm_bfd_start_xmt_timer(struct bfd_session *bfd, bool is_echo)