proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-08 07:37:29 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

vtysh: properly fix memory leak

Browse Source 
Commit 44f12f20 fixed the memory leak in the wrong way and introduced a
"uninitialized variable" warning.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
Renato Westphal 2017-10-25 07:43:32 -02:00
parent b5b583aa8d
commit 80c872f699
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
vtysh/vtysh.c
View File

@ -807,24 +807,26 @@ static int vtysh_rl_describe(void)
fprintf(stdout, "\n"); fprintf(stdout, "\n");
describe = cmd_describe_command(vline, vty, &ret);
/* Ambiguous and no match error. */ /* Ambiguous and no match error. */
switch (ret) { switch (ret) {
case CMD_ERR_AMBIGUOUS: case CMD_ERR_AMBIGUOUS:
cmd_free_strvec(vline); cmd_free_strvec(vline);
vector_free(describe);
fprintf(stdout, "%% Ambiguous command.\n"); fprintf(stdout, "%% Ambiguous command.\n");
rl_on_new_line(); rl_on_new_line();
return 0; return 0;
break; break;
case CMD_ERR_NO_MATCH: case CMD_ERR_NO_MATCH:
cmd_free_strvec(vline); cmd_free_strvec(vline);
vector_free(describe);
fprintf(stdout, "%% There is no matched command.\n"); fprintf(stdout, "%% There is no matched command.\n");
rl_on_new_line(); rl_on_new_line();
return 0; return 0;
break; break;
} }
describe = cmd_describe_command(vline, vty, &ret);
/* Get width of command string. */ /* Get width of command string. */
width = 0; width = 0;
for (i = 0; i < vector_active(describe); i++) for (i = 0; i < vector_active(describe); i++)