proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-27 13:06:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bfdd: don't allow link-local without interface

Browse Source 
When using link-local addresses we must provide scope-id to the
operating system so it knows where to send packets.

Spotted by Pavel Ivashchenko (@zays26).

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
This commit is contained in:
Rafael Zalamena 2019-10-11 16:54:51 -03:00
parent f106240130
commit 80420ce34d
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
bfdd/bfdd_northbound.c
View File

@ -58,10 +58,39 @@ static int bfd_session_create(enum nb_event event, const struct lyd_node *dnode,
union nb_resource *resource, bool mhop) union nb_resource *resource, bool mhop)
{ {
struct bfd_session *bs; struct bfd_session *bs;
const char *ifname;
struct bfd_key bk; struct bfd_key bk;
struct in6_addr i6a;
switch (event) { switch (event) {
case NB_EV_VALIDATE: case NB_EV_VALIDATE:
/*
* When `dest-addr` is IPv6 and link-local we must
* require interface name, otherwise we can't figure
* which interface to use to send the packets.
*
* `memset` `i6a` in case address is IPv4 or non
* link-local IPv6, it should also avoid static
* analyzer warning about unset memory read.
*/
memset(&i6a, 0, sizeof(i6a));
yang_dnode_get_ipv6(&i6a, dnode, "./dest-addr");
/*
* To support old FRR versions we must allow empty
* interface to be specified, however that should
* change in the future.
*/
if (yang_dnode_exists(dnode, "./interface"))
ifname = yang_dnode_get_string(dnode, "./interface");
else
ifname = "";
if (IN6_IS_ADDR_LINKLOCAL(&i6a) && strlen(ifname) == 0) {
zlog_warn("%s: when using link-local you must specify "
"an interface.", __func__);
return NB_ERR_VALIDATION;
}
break; break;
case NB_EV_PREPARE: case NB_EV_PREPARE: