proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 05:18:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

lib: fix usage of getgrouplist() in *BSD

Browse Source 
On BSD systems, the getgrouplist() function returns 0 if successful and
-1 on error.

Linux in the other hand returns *ngroups (the number of groups of which
user is a member) on success and -1 on error.

Given this difference, the most portable way to use getgrouplist()
is use its return value only for checking if it succeeded or not.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
This commit is contained in:
Mike Tancsa 2017-03-31 17:50:35 -03:00 committed by Quentin Young
parent 98b506c210
commit 7e5b539722
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/privs.c
View File

@ -731,7 +731,7 @@ zprivs_init(struct zebra_privs_t *zprivs)
if (zprivs->user) if (zprivs->user)
{ {
ngroups = sizeof(groups); ngroups = sizeof(groups);
if ( (ngroups = getgrouplist (zprivs->user, zprivs_state.zgid, groups, &ngroups )) < 0 ) if (getgrouplist (zprivs->user, zprivs_state.zgid, groups, &ngroups) < 0)
{ {
/* cant use log.h here as it depends on vty */ /* cant use log.h here as it depends on vty */
fprintf (stderr, "privs_init: could not getgrouplist for user %s\n", fprintf (stderr, "privs_init: could not getgrouplist for user %s\n",