bgpd: Somewhat optimize string returns

There is no need for a cascading series of if statements
for the afi.  Clean it up slightly

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2020-12-17 16:33:11 -05:00
parent ff4a6e5d94
commit 7d0d37de0c

View File

@ -209,33 +209,37 @@ static enum node_type bgp_node_type(afi_t afi, safi_t safi)
static const char *get_afi_safi_vty_str(afi_t afi, safi_t safi)
{
if (afi == AFI_IP && safi == SAFI_UNICAST)
if (afi == AFI_IP) {
if (safi == SAFI_UNICAST)
return "IPv4 Unicast";
else if (afi == AFI_IP && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "IPv4 Multicast";
else if (afi == AFI_IP && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "IPv4 Labeled Unicast";
else if (afi == AFI_IP && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "IPv4 VPN";
else if (afi == AFI_IP && safi == SAFI_ENCAP)
if (safi == SAFI_ENCAP)
return "IPv4 Encap";
else if (afi == AFI_IP && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "IPv4 Flowspec";
else if (afi == AFI_IP6 && safi == SAFI_UNICAST)
} else if (afi == AFI_IP6) {
if (safi == SAFI_UNICAST)
return "IPv6 Unicast";
else if (afi == AFI_IP6 && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "IPv6 Multicast";
else if (afi == AFI_IP6 && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "IPv6 Labeled Unicast";
else if (afi == AFI_IP6 && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "IPv6 VPN";
else if (afi == AFI_IP6 && safi == SAFI_ENCAP)
if (safi == SAFI_ENCAP)
return "IPv6 Encap";
else if (afi == AFI_IP6 && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "IPv6 Flowspec";
else if (afi == AFI_L2VPN && safi == SAFI_EVPN)
} else if (afi == AFI_L2VPN) {
if (safi == SAFI_EVPN)
return "L2VPN EVPN";
else
}
return "Unknown";
}
@ -247,33 +251,37 @@ static const char *get_afi_safi_vty_str(afi_t afi, safi_t safi)
*/
static const char *get_afi_safi_json_str(afi_t afi, safi_t safi)
{
if (afi == AFI_IP && safi == SAFI_UNICAST)
if (afi == AFI_IP) {
if (safi == SAFI_UNICAST)
return "ipv4Unicast";
else if (afi == AFI_IP && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "ipv4Multicast";
else if (afi == AFI_IP && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "ipv4LabeledUnicast";
else if (afi == AFI_IP && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "ipv4Vpn";
else if (afi == AFI_IP && safi == SAFI_ENCAP)
if (safi == SAFI_ENCAP)
return "ipv4Encap";
else if (afi == AFI_IP && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "ipv4Flowspec";
else if (afi == AFI_IP6 && safi == SAFI_UNICAST)
} else if (afi == AFI_IP6) {
if (safi == SAFI_UNICAST)
return "ipv6Unicast";
else if (afi == AFI_IP6 && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "ipv6Multicast";
else if (afi == AFI_IP6 && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "ipv6LabeledUnicast";
else if (afi == AFI_IP6 && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "ipv6Vpn";
else if (afi == AFI_IP6 && safi == SAFI_ENCAP)
if (safi == SAFI_ENCAP)
return "ipv6Encap";
else if (afi == AFI_IP6 && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "ipv6Flowspec";
else if (afi == AFI_L2VPN && safi == SAFI_EVPN)
} else if (afi == AFI_L2VPN) {
if (safi == SAFI_EVPN)
return "l2VpnEvpn";
else
}
return "Unknown";
}
@ -282,29 +290,33 @@ static const char *get_afi_safi_json_str(afi_t afi, safi_t safi)
*/
const char *bgp_afi_safi_get_container_str(afi_t afi, safi_t safi)
{
if (afi == AFI_IP && safi == SAFI_UNICAST)
if (afi == AFI_IP) {
if (safi == SAFI_UNICAST)
return "ipv4-unicast";
else if (afi == AFI_IP && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "ipv4-multicast";
else if (afi == AFI_IP && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "ipv4-labeled-unicast";
else if (afi == AFI_IP && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "l3vpn-ipv4-unicast";
else if (afi == AFI_IP && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "ipv4-flowspec";
else if (afi == AFI_IP6 && safi == SAFI_UNICAST)
} else if (afi == AFI_IP6) {
if (safi == SAFI_UNICAST)
return "ipv6-unicast";
else if (afi == AFI_IP6 && safi == SAFI_MULTICAST)
if (safi == SAFI_MULTICAST)
return "ipv6-multicast";
else if (afi == AFI_IP6 && safi == SAFI_LABELED_UNICAST)
if (safi == SAFI_LABELED_UNICAST)
return "ipv6-labeled-unicast";
else if (afi == AFI_IP6 && safi == SAFI_MPLS_VPN)
if (safi == SAFI_MPLS_VPN)
return "l3vpn-ipv6-unicast";
else if (afi == AFI_IP6 && safi == SAFI_FLOWSPEC)
if (safi == SAFI_FLOWSPEC)
return "ipv6-flowspec";
else if (afi == AFI_L2VPN && safi == SAFI_EVPN)
} else if (afi == AFI_L2VPN) {
if (safi == SAFI_EVPN)
return "l2vpn-evpn";
else
}
return "Unknown";
}