proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-08 12:49:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tests: Refactor bgp_maximum_prefix_invalid_update test case

Browse Source 
Just drop `while true` stuff.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2022-11-29 15:30:11 +02:00
parent 27858b3be9
commit 7591803d88
4 changed files with 42 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/topotests/bgp_maximum_prefix_invalid_update/r1/bgpd.conf
View File

@ -4,3 +4,10 @@ router bgp 65000
neighbor 192.168.255.2 timers 3 10 neighbor 192.168.255.2 timers 3 10
address-family ipv4 unicast address-family ipv4 unicast
redistribute connected redistribute connected
neighbor 192.168.255.2 prefix-list r2 out
exit-address-family
!
!
ip prefix-list r2 seq 5 permit 172.16.255.253/32
ip prefix-list r2 seq 10 permit 172.16.255.254/32
!

1
tests/topotests/bgp_maximum_prefix_invalid_update/r1/zebra.conf
View File

@ -1,6 +1,7 @@
! !
interface lo interface lo
ip address 172.16.255.254/32 ip address 172.16.255.254/32
ip address 172.16.255.253/32
! !
interface r1-eth0 interface r1-eth0
ip address 192.168.255.1/24 ip address 192.168.255.1/24

3
tests/topotests/bgp_maximum_prefix_invalid_update/r2/bgpd.conf
View File

@ -4,3 +4,6 @@ router bgp 65001
neighbor 192.168.255.1 timers 3 10 neighbor 192.168.255.1 timers 3 10
address-family ipv4 address-family ipv4
neighbor 192.168.255.1 maximum-prefix 1 neighbor 192.168.255.1 maximum-prefix 1
exit-address-family
!
!

33
tests/topotests/bgp_maximum_prefix_invalid_update/test_bgp_maximum_prefix_invalid_update.py
View File

@ -36,11 +36,13 @@ import os
import sys import sys
import json import json
import pytest import pytest
import functools
CWD = os.path.dirname(os.path.realpath(__file__)) CWD = os.path.dirname(os.path.realpath(__file__))
sys.path.append(os.path.join(CWD, "../")) sys.path.append(os.path.join(CWD, "../"))
# pylint: disable=C0413 # pylint: disable=C0413
from lib import topotest
from lib.topogen import Topogen, TopoRouter, get_topogen from lib.topogen import Topogen, TopoRouter, get_topogen
pytestmark = [pytest.mark.bgpd] pytestmark = [pytest.mark.bgpd]
@ -83,29 +85,36 @@ def test_bgp_maximum_prefix_invalid():
if tgen.routers_have_failure(): if tgen.routers_have_failure():
pytest.skip(tgen.errors) pytest.skip(tgen.errors)
def _bgp_converge(router): r2 = tgen.gears["r2"]
while True:
output = json.loads(
tgen.gears[router].vtysh_cmd("show ip bgp neighbor 192.168.255.1 json")
)
if output["192.168.255.1"]["connectionsEstablished"] > 0:
return True
def _bgp_parsing_nlri(router): def _bgp_converge():
output = json.loads(r2.vtysh_cmd("show ip bgp neighbor 192.168.255.1 json"))
expected = {
"192.168.255.1": {
"connectionsEstablished": 1,
"connectionsDropped": 1,
}
}
return topotest.json_cmp(output, expected)
test_func = functools.partial(_bgp_converge)
_, result = topotest.run_and_expect(test_func, None, count=30, wait=0.5)
assert result is None, "Can't converge initially"
def _bgp_parsing_nlri():
cmd_max_exceeded = ( cmd_max_exceeded = (
'grep "%MAXPFXEXCEED: No. of IPv4 Unicast prefix received" bgpd.log' 'grep "%MAXPFXEXCEED: No. of IPv4 Unicast prefix received" bgpd.log'
) )
cmdt_error_parsing_nlri = 'grep "Error parsing NLRI" bgpd.log' cmdt_error_parsing_nlri = 'grep "Error parsing NLRI" bgpd.log'
output_max_exceeded = tgen.gears[router].run(cmd_max_exceeded) output_max_exceeded = r2.run(cmd_max_exceeded)
output_error_parsing_nlri = tgen.gears[router].run(cmdt_error_parsing_nlri) output_error_parsing_nlri = r2.run(cmdt_error_parsing_nlri)
if len(output_max_exceeded) > 0: if len(output_max_exceeded) > 0:
if len(output_error_parsing_nlri) > 0: if len(output_error_parsing_nlri) > 0:
return False return False
return True return True
if _bgp_converge("r2"): assert _bgp_parsing_nlri() == True
assert _bgp_parsing_nlri("r2") == True
if __name__ == "__main__": if __name__ == "__main__":