From 75839aabb8082037804de7090663ff83f1babbce Mon Sep 17 00:00:00 2001 From: Mark Stapp Date: Mon, 22 Apr 2019 15:49:16 -0400 Subject: [PATCH] lib: fix warning in linklist api Add return value and comment to new/recent linklist api to clean up compile warning. Signed-off-by: Mark Stapp --- lib/linklist.c | 2 +- lib/linklist.h | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/linklist.c b/lib/linklist.c index d3ecc00306..40c4b27169 100644 --- a/lib/linklist.c +++ b/lib/linklist.c @@ -328,7 +328,7 @@ void list_sort(struct list *list, int (*cmp)(const void **, const void **)) XFREE(MTYPE_TMP, items); } -void listnode_add_force(struct list **list, void *val) +struct listnode *listnode_add_force(struct list **list, void *val) { if (*list == NULL) *list = list_new(); diff --git a/lib/linklist.h b/lib/linklist.h index dd90608bcb..c30d8d314a 100644 --- a/lib/linklist.h +++ b/lib/linklist.h @@ -343,7 +343,13 @@ extern void list_add_list(struct list *list, struct list *add); extern struct listnode *listnode_lookup_nocheck(struct list *list, void *data); -extern void listnode_add_force(struct list **list, void *val); +/* + * Add a node to *list, if non-NULL. Otherwise, allocate a new list, mail + * it back in *list, and add a new node. + * + * Return: the new node. + */ +extern struct listnode *listnode_add_force(struct list **list, void *val); #ifdef __cplusplus }