proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-11 22:02:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Prevent ecomm memory leak

Browse Source 
There are some situations where we create a ecommunity for
comparing to internal state when we are deleting, but in the
failure cases we would not free up the created memory.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2020-10-27 15:16:32 -04:00
parent dd51171227
commit 736e6a45e6
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_evpn_vty.c
View File

@ -5297,6 +5297,7 @@ DEFUN (no_bgp_evpn_vrf_rt,
if (rt_type == RT_TYPE_IMPORT) { if (rt_type == RT_TYPE_IMPORT) {
if (!bgp_evpn_rt_matches_existing(bgp->vrf_import_rtl, if (!bgp_evpn_rt_matches_existing(bgp->vrf_import_rtl,
ecomdel)) { ecomdel)) {
ecommunity_free(&ecomdel);
vty_out(vty, vty_out(vty,
"%% RT specified does not match configuration for this VRF\n"); "%% RT specified does not match configuration for this VRF\n");
return CMD_WARNING; return CMD_WARNING;
@ -5305,6 +5306,7 @@ DEFUN (no_bgp_evpn_vrf_rt,
} else if (rt_type == RT_TYPE_EXPORT) { } else if (rt_type == RT_TYPE_EXPORT) {
if (!bgp_evpn_rt_matches_existing(bgp->vrf_export_rtl, if (!bgp_evpn_rt_matches_existing(bgp->vrf_export_rtl,
ecomdel)) { ecomdel)) {
ecommunity_free(&ecomdel);
vty_out(vty, vty_out(vty,
"%% RT specified does not match configuration for this VRF\n"); "%% RT specified does not match configuration for this VRF\n");
return CMD_WARNING; return CMD_WARNING;
@ -5326,12 +5328,14 @@ DEFUN (no_bgp_evpn_vrf_rt,
} }
if (!found_ecomdel) { if (!found_ecomdel) {
ecommunity_free(&ecomdel);
vty_out(vty, vty_out(vty,
"%% RT specified does not match configuration for this VRF\n"); "%% RT specified does not match configuration for this VRF\n");
return CMD_WARNING; return CMD_WARNING;
} }
} }
ecommunity_free(&ecomdel);
return CMD_SUCCESS; return CMD_SUCCESS;
} }