proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-06 14:29:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

ospfd: Memory Leak seen at show_ip_ospf_neighbor_all_common.

Browse Source 
Problem Statement:
==================
Memory Leak seen at  show_ip_ospf_neighbor_all_common (ospf_vty.c:4635)

RCA:
=================
In function show_ip_ospf_neighbor_all_common, one child json object is not
 added to the parent child object when there is no nbma neighbor. Hence
 the memory leak.

Fix:
=================
Add the child object to the parent json object.

Fixes: #9548

Signed-off-by: Mobashshera Rasool <mrasool@vmware.com>
This commit is contained in:
Mobashshera Rasool 2021-09-03 04:06:15 -07:00
parent 3cb67fef98
commit 6f3e19b736
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ospfd/ospf_vty.c
View File

@ -4682,7 +4682,6 @@ static int show_ip_ospf_neighbor_all_common(struct vty *vty, struct ospf *ospf,
json_vrf = json_object_new_object(); json_vrf = json_object_new_object();
else else
json_vrf = json; json_vrf = json;
json_neighbor_sub = json_object_new_object();
} }
ospf_show_vrf_name(ospf, vty, json_vrf, use_vrf); ospf_show_vrf_name(ospf, vty, json_vrf, use_vrf);
@ -4708,6 +4707,8 @@ static int show_ip_ospf_neighbor_all_common(struct vty *vty, struct ospf *ospf,
if (nbr_nbma->nbr == NULL if (nbr_nbma->nbr == NULL
|| nbr_nbma->nbr->state == NSM_Down) { || nbr_nbma->nbr->state == NSM_Down) {
if (use_json) { if (use_json) {
json_neighbor_sub =
json_object_new_object();
json_object_int_add(json_neighbor_sub, json_object_int_add(json_neighbor_sub,
"nbrNbmaPriority", "nbrNbmaPriority",
nbr_nbma->priority); nbr_nbma->priority);