proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-13 10:14:50 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: null check (Coverity 1472965 1472966)

Browse Source 
There were checks for null pointer after being dereferenced. Checks have
been removed (we've discussed the no need of adding assert()'s because
of similar code not requiring them).

Signed-off-by: F. Aragon <paco@voltanet.io>
This commit is contained in:
F. Aragon 2018-09-20 16:00:40 +02:00
parent dc790ba83d
commit 6ea591c700
No known key found for this signature in database
GPG Key ID: FD112A8C7E6A5E4A
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bgpd/bgp_pbr.c
View File

@ -1882,14 +1882,14 @@ static void bgp_pbr_policyroute_add_to_zebra_unit(struct bgp *bgp,
}
/* ipset create */
if (bpm && !bpm->installed)
if (!bpm->installed)
bgp_send_pbr_ipset_match(bpm, true);
/* ipset add */
if (bpme && !bpme->installed)
if (!bpme->installed)
bgp_send_pbr_ipset_entry_match(bpme, true);
/* iptables */
if (bpm && !bpm->installed_in_iptable)
if (!bpm->installed_in_iptable)
bgp_send_pbr_iptable(bpa, bpm, true);
/* A previous entry may already exist