proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-15 13:27:53 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #9039 from ton31337/fix/no_need_to_check_for_null_in_cmp_functions

Browse Source 
bgpd: Do not check for NULL values for vni_hash_cmp()
This commit is contained in:
Donald Sharp 2021-07-13 16:42:23 -04:00 committed by GitHub
commit 6e95e6419c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bgpd/bgp_evpn.c
View File

@ -111,11 +111,7 @@ static bool vni_hash_cmp(const void *p1, const void *p2)
const struct bgpevpn *vpn1 = p1; const struct bgpevpn *vpn1 = p1;
const struct bgpevpn *vpn2 = p2; const struct bgpevpn *vpn2 = p2;
if (!vpn1 && !vpn2) return vpn1->vni == vpn2->vni;
return true;
if (!vpn1 || !vpn2)
return false;
return (vpn1->vni == vpn2->vni);
} }
int vni_list_cmp(void *p1, void *p2) int vni_list_cmp(void *p1, void *p2)

20
tools/coccinelle/hash_compare_null_values_check.cocci Normal file
View File

@ -0,0 +1,20 @@
// There is no need to test for null values in the hash compare
// function as that we are guaranteed to send in data in
// the hash compare functions.
@@
identifier fn =~ "_hash_cmp";
type T;
identifier p1;
identifier p2;
@@
?static
T fn(...)
{
...
- if (p1 == NULL && p2 == NULL)
- return ...;
- if (p1 == NULL || p2 == NULL)
- return ...;
...
}