proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-16 00:25:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: Set the software version capability received flag only after a validation

Browse Source 
We shouldn't set it blindly once the packet is received, but first we have to
do some sanity checks.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
This commit is contained in:
Donatas Abraitis 2023-11-08 15:26:40 +02:00
parent f6d708bc80
commit 6af683039f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_open.c
View File

@ -896,8 +896,6 @@ static int bgp_capability_software_version(struct peer *peer,
size_t end = stream_get_getp(s) + hdr->length; size_t end = stream_get_getp(s) + hdr->length;
uint8_t len; uint8_t len;
SET_FLAG(peer->cap, PEER_CAP_SOFT_VERSION_RCV);
len = stream_getc(s); len = stream_getc(s);
if (stream_get_getp(s) + len > end) { if (stream_get_getp(s) + len > end) {
flog_warn( flog_warn(
@ -907,6 +905,8 @@ static int bgp_capability_software_version(struct peer *peer,
return -1; return -1;
} }
SET_FLAG(peer->cap, PEER_CAP_SOFT_VERSION_RCV);
if (len > BGP_MAX_SOFT_VERSION) { if (len > BGP_MAX_SOFT_VERSION) {
flog_warn(EC_BGP_CAPABILITY_INVALID_LENGTH, flog_warn(EC_BGP_CAPABILITY_INVALID_LENGTH,
"%s: Received Software Version, but the length is too big, truncating, from peer %s", "%s: Received Software Version, but the length is too big, truncating, from peer %s",