proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-05-01 12:50:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: optimize holdtime timer cancelling

Browse Source 
* bgp_packet.c: (bgp_update_receive) for every update received we queue
  an event just to cancel the holdtime timer, done in bgp_fsm_update().
  Instead cancel the timer directly an avoid a scheduling pass.

  This incidently fixes another problem found on a slow box, where thousands
of events threads were queued, and run, but never freed, because they are
moved to the unused list that grows without bounds.

Signed-off-by: Jorge Boncompte [DTI2] <jorge@dti2.net>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This commit is contained in:
Jorge Boncompte [DTI2] 2012-05-07 16:53:07 +00:00 committed by David Lamparter
parent 577ac57b78
commit 6a4677b723
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
bgpd/bgp_packet.c
View File

@ -1854,8 +1854,8 @@ bgp_update_receive (struct peer *peer, bgp_size_t size)
peer->update_in++;
peer->update_time = bgp_clock ();
/* Generate BGP event. */
BGP_EVENT_ADD (peer, Receive_UPDATE_message);
/* Cancel holdtime timer */
BGP_TIMER_OFF (peer->t_holdtime);
return 0;
}