proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-08-13 01:38:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

bgpd: zlog_warn to assert for code that must be executed first

Browse Source 
In bgp_keepalives.c, it was noticed that we were
ensuring that we called an intialization function first,
but this is a development escape in that once this
was fixed we never see it.  So if a developer moves
this assumption around, let's crash the program and
lead them to this spot instead of silently ignoring
the problem.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
This commit is contained in:
Donald Sharp 2018-08-15 20:44:31 -04:00
parent deff24cad5
commit 68ede9c401
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
bgpd/bgp_keepalives.c
View File

@ -239,10 +239,10 @@ void bgp_keepalives_on(struct peer *peer)
/* placeholder bucket data to use for fast key lookups */ /* placeholder bucket data to use for fast key lookups */
static struct pkat holder = {0}; static struct pkat holder = {0};
if (!peerhash_mtx) { /*
zlog_warn("%s: call bgp_keepalives_init() first", __func__); * We need to ensure that bgp_keepalives_init was called first
return; */
} assert(peerhash_mtx);
pthread_mutex_lock(peerhash_mtx); pthread_mutex_lock(peerhash_mtx);
{ {
@ -269,10 +269,10 @@ void bgp_keepalives_off(struct peer *peer)
/* placeholder bucket data to use for fast key lookups */ /* placeholder bucket data to use for fast key lookups */
static struct pkat holder = {0}; static struct pkat holder = {0};
if (!peerhash_mtx) { /*
zlog_warn("%s: call bgp_keepalives_init() first", __func__); * We need to ensure that bgp_keepalives_init was called first
return; */
} assert(peerhash_mtx);
pthread_mutex_lock(peerhash_mtx); pthread_mutex_lock(peerhash_mtx);
{ {