proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-04-29 18:10:23 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

babeld: ignore nonzero flag bits in Hello TLVs

Browse Source 
Ignore all other bits(except U) in Hello TLVs, according to RFC8966
Signed-off-by: zmw12306 <zmw12306@gmail.com>
This commit is contained in:
zmw12306 2023-04-22 15:11:13 -04:00
parent c53ab57b79
commit 673f1d4d57
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
babeld/message.c
View File

@ -413,18 +413,6 @@ parse_packet(const unsigned char *from, struct interface *ifp,
#define BABEL_UNICAST_HELLO 0x8000 #define BABEL_UNICAST_HELLO 0x8000
DO_NTOHS(flags, message + 2); DO_NTOHS(flags, message + 2);
/*
* RFC 8966 4.6.5
* All other bits MUST be sent as a 0 and silently
* ignored on reception
*/
if (CHECK_FLAG(flags, ~BABEL_UNICAST_HELLO)) {
debugf(BABEL_DEBUG_COMMON,
"Received Hello from %s on %s that does not have all 0's in the unused section of flags, ignoring",
format_address(from), ifp->name);
goto done;
}
/* /*
* RFC 8966 Appendix F * RFC 8966 Appendix F
* TL;DR -> Please ignore Unicast hellos until FRR's * TL;DR -> Please ignore Unicast hellos until FRR's