proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-07-14 05:28:59 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

zebra: Ensure dplane does not send work back to master at wrong time

Browse Source 
When looping through the dplane providers, the worklist was
being populated with items from the last provider and then
the event system was checked to see if we should stop processing.
If the event system says `yes` then the dplane code would stop
and send the worklist to the master zebra pthread for collection.
This obviously skipped the next dplane provider on the list
which is double plus not good.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
This commit is contained in:
Donald Sharp 2025-01-31 12:38:20 -05:00
parent 07a803a7b3
commit 64709ec2a9
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
zebra/zebra_dplane.c
View File

@ -7528,6 +7528,16 @@ static void dplane_thread_loop(struct event *event)
if (!zdplane_info.dg_run)
break;
/*
* The yield should only happen after a bit of work has been
* done but before we pull any new work off any provider
* queue to continue looping. This is a safe spot to
* do so.
*/
if (event_should_yield(event)) {
reschedule = true;
break;
}
/* Locate next provider */
next_prov = dplane_prov_list_next(&zdplane_info.dg_providers,
prov);
@ -7592,11 +7602,6 @@ static void dplane_thread_loop(struct event *event)
zlog_debug("dplane dequeues %d completed work from provider %s",
counter, dplane_provider_get_name(prov));
if (event_should_yield(event)) {
reschedule = true;
break;
}
/* Locate next provider */
prov = next_prov;
}