From 60f9275a8cbf5a21047459e92913763ed99eb810 Mon Sep 17 00:00:00 2001 From: Louis Scalbert Date: Wed, 19 Apr 2023 15:11:36 +0200 Subject: [PATCH] isisd: fix potential null pointer in isis_affinity_map_update() Reported by coverity scanner #1560315 Do not attempt to update the affinity map if the main isis struct is not yet created. Fixes: 9a65cf35da ("isisd: add affinity-map configuration hooks") Signed-off-by: Louis Scalbert --- isisd/isis_affinitymap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/isisd/isis_affinitymap.c b/isisd/isis_affinitymap.c index 3160427e4b..41bad0a7d9 100644 --- a/isisd/isis_affinitymap.c +++ b/isisd/isis_affinitymap.c @@ -49,6 +49,9 @@ static void isis_affinity_map_update(const char *affmap_name, uint16_t old_pos, struct flex_algo *fa; bool changed; + if (!isis) + return; + for (ALL_LIST_ELEMENTS_RO(isis->area_list, area_node, area)) { changed = false; for (ALL_LIST_ELEMENTS_RO(area->flex_algos->flex_algos, fa_node,