proxmox-mirrors/mirror_frr
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_frr synced 2025-06-15 10:57:01 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge pull request #13578 from opensourcerouting/fix/ripd_argv_find

Browse Source 
ripd: Use argv_find to avoid buffer overflow when parsing allow-ecmp args
This commit is contained in:
Russ White 2023-05-23 08:20:07 -04:00 committed by GitHub
commit 5db30e7958
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ripd/rip_cli.c
View File

@ -91,11 +91,11 @@ DEFUN_YANG (rip_allow_ecmp,
"Allow Equal Cost MultiPath\n" "Allow Equal Cost MultiPath\n"
"Number of paths\n") "Number of paths\n")
{ {
int idx_number = 1; int idx_number = 0;
char mpaths[3] = {}; char mpaths[3] = {};
uint32_t paths = MULTIPATH_NUM; uint32_t paths = MULTIPATH_NUM;
if (argv[idx_number]) if (argv_find(argv, argc, CMD_RANGE_STR(1, MULTIPATH_NUM), &idx_number))
paths = strtol(argv[idx_number]->arg, NULL, 10); paths = strtol(argv[idx_number]->arg, NULL, 10);
snprintf(mpaths, sizeof(mpaths), "%u", paths); snprintf(mpaths, sizeof(mpaths), "%u", paths);